CI: Use TLAUC --skip numsets instead of unicode_number_set_shim.py#181
Merged
Conversation
Use feature introduced in tlaplus-community/tlauc#23 Before these changes, the unicode_number_set_shim.py script was needed to rewrite all specs so they would import a shim version of the Naturals, Integers, and Reals standard modules that defined the ℕ, ℤ, and ℝ number sets. This was a very involved and brittle process, although it did showcase the power of the tree-sitter grammar queries. Now we can simply skip translating those number sets until tlaplus/tlaplus#1020 is fixed. Thus there is no need for the shim script. Signed-off-by: Andrew Helwer <ahelwer@pm.me>
ahelwer
force-pushed
the
tlauc-skip-numsets
branch
from
e3167f5 to
e101193
Compare
ahelwer
added a commit
to ahelwer/tlaplus
that referenced
this pull request
Aug 6, 2025
Script was removed in tlaplus/Examples#181 Signed-off-by: Andrew Helwer <ahelwer@pm.me>
lemmy
pushed a commit
to tlaplus/tlaplus
that referenced
this pull request
Aug 11, 2025
Script was removed in tlaplus/Examples#181 Signed-off-by: Andrew Helwer <ahelwer@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use feature introduced in tlaplus-community/tlauc#23
Before these changes, the unicode_number_set_shim.py script was needed to rewrite all specs so they would import a shim version of the Naturals, Integers, and Reals standard modules that defined the ℕ, ℤ, and ℝ number sets. This was a very involved and brittle process, although it did showcase the power of the tree-sitter grammar queries. Now we can simply skip translating those number sets until tlaplus/tlaplus#1020 is fixed. Thus there is no need for the shim script.